Repository navigation
fix: Prevent incorrect dashboard side panel close - #1372
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 4acf4ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
✅ No critical issues found. This is a clean fix that removes custom click-outside handling in favor of Mantine's built-in Drawer behavior, which correctly handles nested panel interactions. The subdrawer check in the |
pulpdrew
force-pushed
the
drew/remove-click-outside
branch
from
November 17, 2025 13:16
8e7b9ba to
4d96e62
Compare
Contributor
E2E Test Results✅ All tests passed • 38 passed • 3 skipped • 415s
|
pulpdrew
marked this pull request as ready for review
November 17, 2025 13:20
knudtty
pushed a commit
that referenced
this pull request
Apr 16, 2026
Closes #1324 Closes HDX-2724 This PR fixes a bug that caused the Side Panel to close when clicked when on a dashboard with more than one Search Table tile. The fix was to remove the `useClickOutside` hook in favor of Mantine's default behavior, which is to close when clicking outside the drawer.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1324
Closes HDX-2724
This PR fixes a bug that caused the Side Panel to close when clicked when on a dashboard with more than one Search Table tile. The fix was to remove the
useClickOutsidehook in favor of Mantine's default behavior, which is to close when clicking outside the drawer.